-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom date format in date plugin for list rendering. #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadar
requested changes
Mar 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, please add a changelog entry.
nadar
approved these changes
Mar 5, 2019
nadar
requested changes
Mar 5, 2019
nadar
approved these changes
Mar 5, 2019
nadar
pushed a commit
that referenced
this pull request
Apr 9, 2019
* Block Preview styling * Tooltip preview fix #246 * Date plugin with custom format * Changelog for #270 * Refactored namespace using * Unittest for proxy sync with sql error close #229 * Update ClientTable.php * Refactoring * Refactoring * UnitTest notice exception * Unit test fiexed * Unit test fixed * Unit test expected excaption message * Unit test expected excaption message * Unit test expected exception message
nadar
pushed a commit
that referenced
this pull request
May 11, 2019
nadar
pushed a commit
that referenced
this pull request
May 20, 2019
* Block Preview styling * Tooltip preview fix #246 * Alternative proxy db connection * Date plugin with custom format * Changelog for #270 * Refactored namespace using * PHP Doc * Changelog #271 * Update Module.php * Refactoring proxy connection * Refactoring proxy connection * Refactoring proxy connection * Refactoring proxy connection * Unit test fixed * Unit test fixed * Syntax fix * PhpDocs * PhpDocs * Refactoring * Refactoring * Refactoring * Refactoring
nadar
pushed a commit
that referenced
this pull request
Dec 4, 2019
* Block Preview styling * Tooltip preview fix #246 * Date plugin with custom format * Changelog for #270 * Refactored namespace using * Connection lost handling * Unit test fixed close #229 * CONNECTION_ID only available in mysql * Block Preview styling * Tooltip preview fix #246 * travis tests with php 7.4 * clean up dist
nadar
pushed a commit
that referenced
this pull request
Dec 19, 2019
* Block Preview styling * Tooltip preview fix #246 * Date plugin with custom format * Changelog for #270 * Refactored namespace using * Connection lost handling * Unit test fixed close #229 * CONNECTION_ID only available in mysql * Block Preview styling * Tooltip preview fix #246 * travis tests with php 7.4 * clean up dist
nadar
added a commit
that referenced
this pull request
Dec 19, 2019
* add basic idea * add debug info * Thai language translation (#378) * partial translation of thai localization * fully thai translation * Update Module.php * fix sorting, add sorting relation hint. * concept for beforeListFind callable (#382) * concept for beforeListFind callable * add test * add changelog * Update CHANGELOG.md * fix issue with after find values (#388) * fix issue with after find values * add changelog, test and className update * not found error * prepare for release * Update BaseFileSystemStorageTest.php (#390) Replaced / to DIRECTORY_SEPARATOR for passing tests on Windows * skip if pool identifier does not exists. (#392) * skip if pool identifier does not exists. * add changelog and since * fix test * add where condition * handle plugin objects within i18n fallback value (#398) * handle plugin objects within i18n fallback value * add since, update changelog * newline... * run in seperate process * fix test * add whiteliste (#402) * add whiteliste * update code * add unit test * add audience and issuer properties * Use ngRestFind() instead (#403) * Use ngRestFind() insstead * add changelog * New Tag Delete Active Window (#399) * add test and basic concept * add hint and form * run in seperate * fix test * add success delete teste * add error test * attach window to model * add delete * improve ui view * tests * add translations * Update admin.php (#405) * Update admin.php * Update admin.php * Update admin.php * add missing translations * add opcache reset * Use ngRestFind() for API delete action. (#406) * ngrest find and delete * add not found exception test * ngrest raw input/output plugin (#407) * add raw plugin * add changelog and "test" * add update to "test" * add bootstrap tests * remove redundant execution of queue jobs (#396) * remove redundant execution of queue jobs (there is another in bootstrap yet) * run queue job in bootstrap for non admin context too * add changelog * use model as fixture * prepare for release * espace aws delete hint message * escape translation word * Bootstrap Queue CLI Commands (#410) * bootstrap cli command * fix admin queue name * use luya bootstrap method * lock file with latest version * Update CHANGELOG.md * lock file * add default option for retryable jobs * update error message in queue log * use error in exec event * ensure error exists * Disable Queue (#413) * Update Module.php * add changelog and fix * Travis with php 7.4 (#416) * Block Preview styling * Tooltip preview fix #246 * Date plugin with custom format * Changelog for #270 * Refactored namespace using * Connection lost handling * Unit test fixed close #229 * CONNECTION_ID only available in mysql * Block Preview styling * Tooltip preview fix #246 * travis tests with php 7.4 * clean up dist * user friendly exception (#412) * user friendly exception * improve message * add test * change cache behavior * Update Module.php * fix issue with title length when large error messages appear * use luya select for ngrest filters (#419) * use luya select for ngrest filters * add syntax error test * changelog * fix changelog * ensure group value is rendered trough plugins (#420) * ensure group value is rendered trough plugins * add changelog * lazy load certain methods (#422) * lazy load certain methods * add tests * add test * add tests * remove unused code * check for scalar (#423) * check for scalar * add test * phpdoc * this closes #415 * prepare for release * typos * active buttons fix (#424) * active buttons fix * Update CHANGELOG.md * Update ConfigTest.php * Update ConfigTest.php * echarts update closes #428 * fix bug with color plugin, closes #426 * remove deprecated function can #429 * remove deprecated method test * add readonly option (#430) * add readonly option * add test * add missing changelog * add docs and grouped index * add changelog
nadar
added a commit
that referenced
this pull request
Jul 20, 2020
* Block Preview styling * Tooltip preview fix #246 * Date plugin with custom format * Changelog for #270 * Refactored namespace using * Connection lost handling * Unit test fixed close #229 * CONNECTION_ID only available in mysql * Block Preview styling * Tooltip preview fix #246 * travis tests with php 7.4 * clean up dist * attache find behaviours * Changelogs * Unit tests * phpdocs & changelog * Update NgRestModel.php * Update NgRestModel.php * Update NgRestModel.php * Update TestNgRestModel.php Co-authored-by: Basil <git@nadar.io>
nadar
added a commit
that referenced
this pull request
Jul 31, 2020
* Block Preview styling * Tooltip preview fix #246 * Date plugin with custom format * Changelog for #270 * Refactored namespace using * Connection lost handling * Unit test fixed close #229 * CONNECTION_ID only available in mysql * Block Preview styling * Tooltip preview fix #246 * travis tests with php 7.4 * clean up dist * attache find behaviours * Changelogs * Unit tests * phpdocs & changelog * Update NgRestModel.php * Update NgRestModel.php * Update NgRestModel.php * Update TestNgRestModel.php * SoftDeleteTraitTest * SoftDeleteTraitTest * use static tablename * SoftDeleteTraitTest * execute truncate * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Basil <git@nadar.io>
slowfox089
pushed a commit
to slowfox089/luya-module-admin
that referenced
this pull request
Dec 10, 2020
* Block Preview styling * Tooltip preview fix luyadev#246 * Date plugin with custom format * Changelog for luyadev#270 * Refactored namespace using * Connection lost handling * Unit test fixed close luyadev#229 * CONNECTION_ID only available in mysql * Block Preview styling * Tooltip preview fix luyadev#246 * travis tests with php 7.4 * clean up dist
slowfox089
pushed a commit
to slowfox089/luya-module-admin
that referenced
this pull request
Dec 10, 2020
* add basic idea * add debug info * Thai language translation (luyadev#378) * partial translation of thai localization * fully thai translation * Update Module.php * fix sorting, add sorting relation hint. * concept for beforeListFind callable (luyadev#382) * concept for beforeListFind callable * add test * add changelog * Update CHANGELOG.md * fix issue with after find values (luyadev#388) * fix issue with after find values * add changelog, test and className update * not found error * prepare for release * Update BaseFileSystemStorageTest.php (luyadev#390) Replaced / to DIRECTORY_SEPARATOR for passing tests on Windows * skip if pool identifier does not exists. (luyadev#392) * skip if pool identifier does not exists. * add changelog and since * fix test * add where condition * handle plugin objects within i18n fallback value (luyadev#398) * handle plugin objects within i18n fallback value * add since, update changelog * newline... * run in seperate process * fix test * add whiteliste (luyadev#402) * add whiteliste * update code * add unit test * add audience and issuer properties * Use ngRestFind() instead (luyadev#403) * Use ngRestFind() insstead * add changelog * New Tag Delete Active Window (luyadev#399) * add test and basic concept * add hint and form * run in seperate * fix test * add success delete teste * add error test * attach window to model * add delete * improve ui view * tests * add translations * Update admin.php (luyadev#405) * Update admin.php * Update admin.php * Update admin.php * add missing translations * add opcache reset * Use ngRestFind() for API delete action. (luyadev#406) * ngrest find and delete * add not found exception test * ngrest raw input/output plugin (luyadev#407) * add raw plugin * add changelog and "test" * add update to "test" * add bootstrap tests * remove redundant execution of queue jobs (luyadev#396) * remove redundant execution of queue jobs (there is another in bootstrap yet) * run queue job in bootstrap for non admin context too * add changelog * use model as fixture * prepare for release * espace aws delete hint message * escape translation word * Bootstrap Queue CLI Commands (luyadev#410) * bootstrap cli command * fix admin queue name * use luya bootstrap method * lock file with latest version * Update CHANGELOG.md * lock file * add default option for retryable jobs * update error message in queue log * use error in exec event * ensure error exists * Disable Queue (luyadev#413) * Update Module.php * add changelog and fix * Travis with php 7.4 (luyadev#416) * Block Preview styling * Tooltip preview fix luyadev#246 * Date plugin with custom format * Changelog for luyadev#270 * Refactored namespace using * Connection lost handling * Unit test fixed close luyadev#229 * CONNECTION_ID only available in mysql * Block Preview styling * Tooltip preview fix luyadev#246 * travis tests with php 7.4 * clean up dist * user friendly exception (luyadev#412) * user friendly exception * improve message * add test * change cache behavior * Update Module.php * fix issue with title length when large error messages appear * use luya select for ngrest filters (luyadev#419) * use luya select for ngrest filters * add syntax error test * changelog * fix changelog * ensure group value is rendered trough plugins (luyadev#420) * ensure group value is rendered trough plugins * add changelog * lazy load certain methods (luyadev#422) * lazy load certain methods * add tests * add test * add tests * remove unused code * check for scalar (luyadev#423) * check for scalar * add test * phpdoc * this closes luyadev#415 * prepare for release * typos * active buttons fix (luyadev#424) * active buttons fix * Update CHANGELOG.md * Update ConfigTest.php * Update ConfigTest.php * echarts update closes luyadev#428 * fix bug with color plugin, closes luyadev#426 * remove deprecated function can luyadev#429 * remove deprecated method test * add readonly option (luyadev#430) * add readonly option * add test * add missing changelog * add docs and grouped index * add changelog
slowfox089
pushed a commit
to slowfox089/luya-module-admin
that referenced
this pull request
Dec 10, 2020
* Block Preview styling * Tooltip preview fix luyadev#246 * Date plugin with custom format * Changelog for luyadev#270 * Refactored namespace using * Connection lost handling * Unit test fixed close luyadev#229 * CONNECTION_ID only available in mysql * Block Preview styling * Tooltip preview fix luyadev#246 * travis tests with php 7.4 * clean up dist * attache find behaviours * Changelogs * Unit tests * phpdocs & changelog * Update NgRestModel.php * Update NgRestModel.php * Update NgRestModel.php * Update TestNgRestModel.php Co-authored-by: Basil <git@nadar.io>
slowfox089
pushed a commit
to slowfox089/luya-module-admin
that referenced
this pull request
Dec 10, 2020
* Block Preview styling * Tooltip preview fix luyadev#246 * Date plugin with custom format * Changelog for luyadev#270 * Refactored namespace using * Connection lost handling * Unit test fixed close luyadev#229 * CONNECTION_ID only available in mysql * Block Preview styling * Tooltip preview fix luyadev#246 * travis tests with php 7.4 * clean up dist * attache find behaviours * Changelogs * Unit tests * phpdocs & changelog * Update NgRestModel.php * Update NgRestModel.php * Update NgRestModel.php * Update TestNgRestModel.php * SoftDeleteTraitTest * SoftDeleteTraitTest * use static tablename * SoftDeleteTraitTest * execute truncate * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Basil <git@nadar.io>
nadar
added a commit
that referenced
this pull request
Jun 14, 2021
* Block Preview styling * Tooltip preview fix #246 * Date plugin with custom format * Changelog for #270 * Refactored namespace using * Connection lost handling * Unit test fixed close #229 * CONNECTION_ID only available in mysql * Block Preview styling * Tooltip preview fix #246 * travis tests with php 7.4 * clean up dist * attache find behaviours * Changelogs * Unit tests * phpdocs & changelog * Update NgRestModel.php * Update NgRestModel.php * Update NgRestModel.php * Update TestNgRestModel.php * lazy data load for ngrest plugin * changelog * phpdocs for LazyDataLoadTrait * lazyDataLoad Test * lazyDataLoad Test * lazyDataLoad Test Co-authored-by: Basil <git@nadar.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does is it require a unit test? I'm not sure how to test it.