Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

securefileupload csv #66

Closed
nadar opened this issue Feb 25, 2018 · 1 comment
Closed

securefileupload csv #66

nadar opened this issue Feb 25, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@nadar
Copy link
Member

nadar commented Feb 25, 2018

when uploading a csv file text/plain is detected, turning off secure file upload will not work as the mime type is not empty.

Provide an option to whitelist given mime types.

@nadar nadar self-assigned this Feb 25, 2018
@nadar nadar added the bug label Feb 25, 2018
@nadar
Copy link
Member Author

nadar commented Feb 25, 2018

This is the case when uploading .csv files which are detected as mime type text/plain. Therefore you can whiteliste the text/plain. Keep in mind this can be a security risk and is therefore not recommend.

'storage' => [
	'class' => 'luya\admin\filesystem\LocalFileSystem',
    	'whitelistMimeTypes' => ['text/plain'],
]

nadar added a commit that referenced this issue Feb 25, 2018
nadar added a commit that referenced this issue Feb 26, 2018
@nadar nadar added this to the 1.1.0 milestone Mar 5, 2018
@nadar nadar closed this as completed Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant