Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Js code minification #90

Closed
nadar opened this issue Apr 9, 2018 · 1 comment
Closed

Js code minification #90

nadar opened this issue Apr 9, 2018 · 1 comment
Assignees
@nadar @TheMaaarc
Labels
security
Milestone
1.2.0

Comments

@nadar
Copy link
Member

nadar commented Apr 9, 2018

The Js code for login.js and main.js should be minified.

  1. Angular controller, directive and services needs to be rewritten ['$scope', function($scope) { } ]
  2. @TheMaaarc Gulp work flow must have the option to make true minifcation (replace var names with a,b,c and so on)
@nadar nadar added the security label Apr 9, 2018
@TheMaaarc
Copy link
Member

Okay, will check what plugin we can use to uglify our code

@nadar nadar added this to the 1.2.0 milestone Apr 17, 2018
nadar added a commit that referenced this issue Apr 17, 2018
@nadar
prepare angular code for uglify #90
2e95eda
nadar added a commit that referenced this issue Apr 17, 2018
@nadar
prepare for angular uglify #90
67de6aa
nadar added a commit that referenced this issue Apr 18, 2018
@nadar
use strict di mode #90
9bdec5b
nadar added a commit that referenced this issue Apr 18, 2018
@nadar
uglify controllers #90
78bfa4f
This was referenced Apr 18, 2018
Merged
Closed
nadar added a commit that referenced this issue Apr 24, 2018
@nadar
remove strict usage, temp disable resolve injector provider #90
901eefe
nadar added a commit that referenced this issue Apr 25, 2018
@nadar
fix service resolver config #90
4caf4f7
nadar added a commit that referenced this issue Apr 25, 2018
@nadar
changelog and upgrade #90
d75cfe2
nadar added a commit that referenced this issue Apr 26, 2018
@nadar
fix di injection #90
e923466
nadar added a commit that referenced this issue Apr 26, 2018
@nadar
fix wrong di usage #90
83615f0
nadar added a commit that referenced this issue Apr 27, 2018
@nadar
fix strict di bug #90
ceb7137
@nadar nadar closed this as completed May 2, 2018
nadar added a commit that referenced this issue May 15, 2018
@nadar
fix strict di #90
fba2b52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadar nadar

@TheMaaarc TheMaaarc

Labels
security
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
2 participants
@nadar @TheMaaarc