Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store admin language data in cache #333

Merged
merged 7 commits into from
Jul 3, 2019
Merged

store admin language data in cache #333

merged 7 commits into from
Jul 3, 2019

Conversation

nadar
Copy link
Member

@nadar nadar commented Jul 2, 2019

  • store the admin language component data in the cache.
  • use single query to retrieve language informations from database.

@codeclimate
Copy link

codeclimate bot commented Jul 3, 2019

Code Climate has analyzed commit 43ee21f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 20.3% (0.5% change).

View more on Code Climate.

@nadar nadar marked this pull request as ready for review July 3, 2019 08:58
@nadar nadar self-assigned this Jul 3, 2019
@nadar nadar merged commit b8bfe9d into master Jul 3, 2019
@nadar nadar deleted the admin-cache branch July 3, 2019 09:03
slowfox089 pushed a commit to slowfox089/luya-module-admin that referenced this pull request Dec 10, 2020
* store admin language data in cache

* fix bug

* add changelog, add basic test

* add tests

* add language test with flush

* add lang short code empty test

* add model tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant