Toggle button for ngRestModel #338
Conversation
…into theme-loader-1916
…into theme-loader-1916
|
This is a very good idea, the only draw back against ngrest toggle status is that it contains no scheduling, but an option to make the checkbox unique is very usefull and also something we could use in admin lang ngrest table. Let me know if its ready for review, don't forget to add a PR :-) thanks |
|
@nadar What do you mean with "scheduling"? |
|
They NgRest Plugin: "ToggleStatus" does have the option to schedule the time of toggling. (since admin 2.0 with new scheduler system). |
|
For the first there is no more for the theme topic in the admin module. Only this new action button. |
…-admin into theme-loader-1916
|
Hey @boehsermoe i am looking forward to merge this, i just saw that not all lines are covered by the unit test. not uniqueStatus for example, and setting an active value. Do you think its possible to add those? Thanks a lot |
|
@nadar yes of course. |
|
Code Climate has analyzed commit b1ed3b8 and detected 14 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 22.0% (0.3% change). View more on Code Climate. |
* Themes initialize * Remove unused use * Translations * Refactoring: Rename Themes tp ThemeManager * Travis mysql connection failed * admin cms settings * ActiveButton for toggle status * Moved Theme administration to cmsadmin * Refactoring * Changelog * Refactoring * Refactoring * Refactoring * Update CHANGELOG.md * Unittest fpr toggle button * Test custom enable values close luyadev#338 * Unit test for non unique toggle * More unit test for full coverage
Toggle a value between active and inactive. Also can keep a active status unique for a table.