Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Chinese message #34

Merged
merged 7 commits into from
Jan 3, 2018
Merged

add Chinese message #34

merged 7 commits into from
Jan 3, 2018

Conversation

baqianxin
Copy link
Contributor

@baqianxin baqianxin commented Jan 3, 2018

add the chinese messages

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 14.794% when pulling 61f0fcf on baqianxin:luya-chinese-oom into 33a8bfe on luyadev:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 14.794% when pulling 8f36eca on baqianxin:luya-chinese-oom into 33a8bfe on luyadev:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 14.794% when pulling 8f36eca on baqianxin:luya-chinese-oom into 33a8bfe on luyadev:master.

Copy link
Member

@nadar nadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a changelog entry? And there are a few words which are not translated - any reason for this? Thanks for the translations anyhow!

@baqianxin
Copy link
Contributor Author

OK,I'll try again in English.But I do not know how to add an changelog @

@nadar
Copy link
Member

nadar commented Jan 3, 2018

Just add your changes here: https://github.com/luyadev/luya-module-admin/blob/master/CHANGELOG.md

Like

+ [#34](https://github.com/luyadev/luya-module-admin/pull/34) Added chinese translations

@nadar
Copy link
Member

nadar commented Jan 3, 2018

You should commit here, like github already says

Add more commits by pushing to the luya-chinese-oom branch on baqianxin/luya-module-admin.

There you have to add the changelog commit, in luya-chinese-oom branch of your fork. Then it will be auto added to this PR.

@baqianxin
Copy link
Contributor Author

I can not delete the previous commits.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 14.794% when pulling 09d10d8 on baqianxin:luya-chinese-oom into 33a8bfe on luyadev:master.

@nadar nadar merged commit 9dc2786 into luyadev:master Jan 3, 2018
@baqianxin baqianxin deleted the luya-chinese-oom branch January 3, 2018 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants