Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to disable auto assign #444

Merged
merged 1 commit into from
Feb 4, 2020
Merged

add option to disable auto assign #444

merged 1 commit into from
Feb 4, 2020

Conversation

nadar
Copy link
Member

@nadar nadar commented Jan 24, 2020

this closes #439

@nadar nadar self-assigned this Jan 24, 2020
@codeclimate
Copy link

codeclimate bot commented Jan 24, 2020

Code Climate has analyzed commit 65d8e5e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 31.3% (0.0% change).

View more on Code Climate.

@Antikon
Copy link
Contributor

Antikon commented Jan 24, 2020

It seems to me that in this case (with disabled auto assign) in a CRUD list view we will get the raw value of a field. One of the points of SelectArray plugin is to dispay the "converted" data in a list view also.

Maybe it possible to make conversion on the frontend instead of the backend. We can pass once per page a conversion array, and the angularJs can do the rest. By logic, this plugin is not intended for the large amount of data, so the frontend conversion won't cost much.

@nadar nadar merged commit 65d8e5e into master Feb 4, 2020
@nadar nadar deleted the issue-439 branch February 20, 2020 19:38
@Antikon Antikon mentioned this pull request Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SelectArray and broken relation
2 participants