add new validator #562
Merged
add new validator #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| */ | ||
| class I18nRequiredValidator extends Validator | ||
| { | ||
| public function validateAttribute($model, $attribute) |
There was a problem hiding this comment.
Function validateAttribute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
|
Code Climate has analyzed commit 9635ffa and detected 16 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 48.4% (0.0% change). View more on Code Climate. |
slowfox089
pushed a commit
to slowfox089/luya-module-admin
that referenced
this pull request
Dec 10, 2020
* add new validator * add tests * add tests * de language key * update docs * Text updates * German translation * add missing translation files * add changelog Co-authored-by: Roland Schaub <roland.schaub@zephir.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New i18n attribute required validator.