Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make form inpus rounded #570

Merged
merged 6 commits into from
Sep 30, 2020
Merged

make form inpus rounded #570

merged 6 commits into from
Sep 30, 2020

Conversation

nadar
Copy link
Member

@nadar nadar commented Sep 27, 2020

I have decided to add border radius to the form elements, it looks a bit more modern and also a lot of other elements in luya admin do have that radius. i think it looks nice, hopefully you like it too.

add border radius to inputs:

Bildschirmfoto 2020-09-27 um 11 40 11

Bildschirmfoto 2020-09-27 um 11 40 34

How to fix this problem?

Bildschirmfoto 2020-09-27 um 11 41 30

Bildschirmfoto 2020-09-27 um 11 42 37

i have changed to this:

Bildschirmfoto 2020-09-27 um 12 01 21

@nadar nadar self-assigned this Sep 27, 2020
@codeclimate
Copy link

codeclimate bot commented Sep 30, 2020

Code Climate has analyzed commit b578e91 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 51.1% (0.0% change).

View more on Code Climate.

@TheMaaarc TheMaaarc merged commit ca2554f into master Sep 30, 2020
@TheMaaarc TheMaaarc deleted the make-form-inputs-rounded branch September 30, 2020 17:27
slowfox089 pushed a commit to slowfox089/luya-module-admin that referenced this pull request Dec 10, 2020
* make form inpus rounded
* use scss var, align to same radius size on all elements
* update append form groups
* Updated prepend/append input styles
* Updated datepicker styles (wider, border-radius)
* use zaa select for group by

Co-authored-by: Marc Stampfli <kontakt@marcstampfli.guru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants