Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for multiple radio fields #662

Merged
merged 2 commits into from
Sep 8, 2021
Merged

Fix for multiple radio fields #662

merged 2 commits into from
Sep 8, 2021

Conversation

hbugdoll
Copy link
Member

@hbugdoll hbugdoll commented Sep 8, 2021

@nadar nadar requested a review from TheMaaarc September 8, 2021 09:45
Copy link
Member

@nadar nadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheMaaarc was it that simple?
@hbugdoll please add a changelog, but @TheMaaarc will check for approval.

@hbugdoll
Copy link
Member Author

hbugdoll commented Sep 8, 2021

What are you changing

name attribute of <input type="radio" ...> in directive zaaRadio

What is the reason for changing

Checked radio buttons in multiple radio fields (e.g. in CMS blocks) aren't displayed correctly.

QA

Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues luyadev/luya-module-cms#308

@hbugdoll
Copy link
Member Author

hbugdoll commented Sep 8, 2021

I'm not sure about your processing of JS files for the distribution folder dist.

Maybe the commit hbugdoll@e698902 (change ofdist/main.js) should be also added to this PR.

@nadar
Copy link
Member

nadar commented Sep 8, 2021

We will compile the files after merge

@nadar
Copy link
Member

nadar commented Sep 8, 2021

by "changelog entry" i meant adding this pr to => https://github.com/luyadev/luya-module-admin/blob/master/CHANGELOG.md

@hbugdoll
Copy link
Member Author

hbugdoll commented Sep 8, 2021

We will compile the files after merge

Thanks for this clarification.

by "changelog entry" i meant adding this pr to => https://github.com/luyadev/luya-module-admin/blob/master/CHANGELOG.md

Sorry, misunderstood...

Copy link
Member

@TheMaaarc TheMaaarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display problems with multiple radio button fields in CMS block
3 participants