Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BC] static filter method identifier() #940

Closed
nadar opened this issue Aug 8, 2016 · 0 comments
Closed

[BC] static filter method identifier() #940

nadar opened this issue Aug 8, 2016 · 0 comments
Assignees
@nadar
Labels
architecture
Milestone
1.0.0-beta8

Comments

@nadar
Copy link
Member

nadar commented Aug 8, 2016

In order to use filters in PHP oriented way, the identifier() method should be static. This way you can use them directly within your IDE:

$this->zaaImageUpload(123, MediumThumbnail::identifier());

for example.

BC break
@nadar nadar added this to the 1.0.0-beta8 milestone Aug 8, 2016
@nadar nadar self-assigned this Aug 8, 2016
nadar added a commit that referenced this issue Aug 8, 2016
@nadar
replace noni static identifier() method of filters by static method
145da7c 
identifier() #940
@nadar nadar closed this as completed Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadar nadar

Labels
architecture
Projects
None yet
Milestone
1.0.0-beta8
Development

No branches or pull requests
1 participant
@nadar