Login autofill optimizations

[dev7ch]

No description provided.

[coveralls]

Coverage remained the same at 70.619% when pulling 1cb0a48 on dev7ch:login-autofill into 3f5d7de on luyadev:master.

[nadar]

checkInputLabels() is already execute in the login.js script.

[dev7ch]

yes, but we need to run this function in window on load context.

[nadar]

we did, directly inside the login.js

[nadar]

@dev7ch i just cleanup your code and the logic inside your javascript changes makes no sense as the element checking behavior does not require an ID

var mail = document.getElementById("login-user-email");
var pass = document.getElementById("login-user-password");

so this makes no sense as val contains the element.

And it still does not work

[dev7ch]

i am pretty sure ist an compiling issue, after compile i get this as expected:

But i get also an Angular Error (white screen) after login (compile main.js breaks sth):

Its not related to the login.js, its this issue still persist?

[nadar]

make sure you have run composer install in the admin and cms modules.

[TheMaaarc]

webkit-autofill and moz-autofill are pretty buggy. For example chrome handles type text and password differently, that's why the password label only floats to the top if you click anywhere on the page - until you do that the password field is considered empty by chrome.
I suggest we stop with that floating label stuff and just write the label above the input.

[dev7ch]

@nadar ok thanks, composer update inside admin module fixed copmile issue;

@marc, ok yes, i ve noticed its kind of pretty buggy. I ll keep this in mind for the future but for now i hope the implementation works a bit more reliable then before( testet in Firefox, Chrom, Opera, Safari - latest).

@marc, @nadar is the the floating autofill still not working for you?

[nadar]

i am not sure, i have to rewrite all your code first.

@dev7ch i just cleanup your code and the logic inside your javascript changes makes no sense as the element checking behavior does not require an ID

var mail = document.getElementById("login-user-email");
var pass = document.getElementById("login-user-password");

so this makes no sense as val contains the element.