Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ThemeController.php #2011

Merged
merged 3 commits into from
Apr 9, 2020
Merged

Update ThemeController.php #2011

merged 3 commits into from
Apr 9, 2020

Conversation

JohnnyMcWeed
Copy link
Contributor

@JohnnyMcWeed JohnnyMcWeed commented Apr 8, 2020

What is the reason for changing/introducing

this closes #2010

Copy link
Member

@nadar nadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry, current patch release would be 1.2.2, see changelog.md

@codeclimate
Copy link

codeclimate bot commented Apr 9, 2020

Code Climate has analyzed commit 6b1bd01 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 65.8% (0.0% change).

View more on Code Climate.

@nadar nadar merged commit 112eb9c into luyadev:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme create command not working
3 participants