Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow isAdmin when its a module #2027

Merged
merged 5 commits into from
Jun 4, 2020
Merged

allow isAdmin when its a module #2027

merged 5 commits into from
Jun 4, 2020

Conversation

nadar
Copy link
Contributor

@nadar nadar commented Jun 4, 2020

Fix a bug where newsadmin/default/index would not return isAdmin true and therefore breaks certain situation in luya admin module.

This break has been introduced in https://github.com/luyadev/luya/issues/2019

@codeclimate
Copy link

codeclimate bot commented Jun 4, 2020

Code Climate has analyzed commit a64212c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 66.3% (0.0% change).

View more on Code Climate.

@nadar nadar merged commit d3e0418 into master Jun 4, 2020
@nadar nadar deleted the fix-isadmin-bc-break branch June 4, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant