Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazyload BC Break Fix #2042

Merged
merged 5 commits into from
Jul 28, 2020
Merged

Lazyload BC Break Fix #2042

merged 5 commits into from
Jul 28, 2020

Conversation

TheMaaarc
Copy link
Member

Fixed Polyfill for older browsers.
Added "replacePlaceholder" option (defaults to true).

Fixes #2041

@TheMaaarc TheMaaarc requested a review from nadar July 28, 2020 16:31
var ERR_NON_OBJECT = 'Object.getOwnPropertyDescriptor called on a non-object: ';

/* eslint-disable no-proto */
Object.getOwnPropertyDescriptor = function getOwnPropertyDescriptor(object, property) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function getOwnPropertyDescriptor has 41 lines of code (exceeds 25 allowed). Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Jul 28, 2020

Code Climate has analyzed commit 552ce8b and detected 6 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2
Duplication 4

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 66.5% (0.0% change).

View more on Code Climate.

Copy link
Member

@nadar nadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@nadar nadar merged commit 86ba468 into master Jul 28, 2020
@nadar nadar deleted the lazyload-extraClass-fix branch July 28, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LazyLoad extraClass changed place
2 participants