encode() returns error code if save_file() cannot open output file. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, encode() would return 0 whether or not the output file was created. There was no way for a caller to know when the file could not be created (e.g. due to a non-existent parent directory). Changed save_file() to return error 79 if it cannot open output file. encode() checks return code from save_file() and passes any error value back to the caller.
|
By the way, I should say this is a wonderful piece of code. It is refreshing how easy it is to use and how it just WORKED the first time I used it, without having to fight to get it to compile. Thank you! |
|
Thanks for this fix, good find |
lvandeve
added a commit
that referenced
this pull request
Sep 12, 2015
encode() returns error code if save_file() cannot open output file.
|
sorry for late merge I thought it already was long ago but apparently it wasn't :) |
|
I'm glad I could make this small contribution. On Sat, Sep 12, 2015 at 5:15 PM, Lode Vandevenne notifications@github.com
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, encode() would return 0 whether or not the output
file was created. There was no way for a caller to know when the
file could not be created (e.g. due to a non-existent parent directory).
Changed save_file() to return error 79 if it cannot open output file.
encode() checks return code from save_file() and passes any error value
back to the caller.