binary data breaks wdiff output #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 21, 2023 20:49
Binary data breaks the rfc-diff/wdiff tool since the format doesn't have good carriage returns, etc. It would probably be nicer if the wdiff or rfcdiff would automatically detect binary and do the right thing. (though presumably rfcdiff isn't supposed to be smart enough to handle non-rfc data and pkgdiff is kind of abusing that behavior?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to fix the %% escaping as pointed out by others.
I also have large binary data files in my RPMs and rfcdiff/wdiff attempt to diff them and fail miserably, and messes up the output, causing the tool to end up saying the binary files have not changed. This is spite of the file size and contents changing, which is confusing to me. Seem like there might be a better way to do a "regular" diff on the files, and if they are binary, skip all other parsing?
Changing the default DATA FileType to Binary is enough to fix it for me, but there might be a better solution that works for more people, I'm not sure.