Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LVGL to v9 #69

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Update LVGL to v9 #69

merged 2 commits into from
Jan 24, 2024

Conversation

PGNetHun
Copy link
Collaborator

@PGNetHun PGNetHun commented Jan 23, 2024 •
edited
Loading

Update master branch to LVGL v9: lvgl/lvgl@09cb87c

@PGNetHun PGNetHun requested a review from kisvegabor January 23, 2024 21:33
@PGNetHun
Copy link
Collaborator Author

@kisvegabor
Can you please approve PR?

@PGNetHun PGNetHun changed the title Update LVGL Update LVGL to 9.0 Jan 23, 2024
@PGNetHun PGNetHun changed the title Update LVGL to 9.0 Update LVGL to v9 Jan 23, 2024
@PGNetHun
Copy link
Collaborator Author

Reminder:
After PR is merged to master, do not forget to update LVGL MicroPython CI build:
https://github.com/lvgl/lvgl/blob/master/.github/workflows/build_micropython.yml#L26

@kisvegabor
Copy link
Member

I don't know if you would you like to squash or rebase the PRs, so leave merging to you 🙂

@kisvegabor kisvegabor mentioned this pull request Jan 24, 2024
Merged
@kisvegabor
Copy link
Member

lvgl/lvgl#5460 will update the CI.

@PGNetHun
Copy link
Collaborator Author

I don't know if you would you like to squash or rebase the PRs, so leave merging to you 🙂

Squash merge. Is that OK for you?

@PGNetHun
Copy link
Collaborator Author

But there is another problem:
Although I have write access to repo, but I'm not authorized to merge PR:
image

@kisvegabor
Copy link
Member

kisvegabor commented Jan 24, 2024 •
edited
Loading

I've updated some settings. Does merging work now?

@PGNetHun
Copy link
Collaborator Author

I've updated some settings. Does merging work now?

Yes, from my forked repo to feat/multi-instace branch PR merging worked: #68
But merging from feat/multi-instance to master is not enabled for me, 'cause I'm not authorized.

@kisvegabor
Copy link
Member

Now I removed all rules from the master branch. Let's see if it works now. If not, maybe it's just not applied for old PRs.

@PGNetHun PGNetHun merged commit 7ff7d1c into lvgl:master Jan 24, 2024
5 checks passed
@PGNetHun
Copy link
Collaborator Author

PGNetHun commented Jan 24, 2024 •
edited
Loading

@kisvegabor
It works now, PR is merged to master.
Thank you!

@kisvegabor
Copy link
Member

Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kisvegabor kisvegabor kisvegabor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PGNetHun @kisvegabor