-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add touch input values to an accessible FreeRTOS queue #136
Conversation
@tore-espressif @C47D, would love to have your inputs/review. |
Hi, Sorry for the late reply, it looks good to me, do you think we could make it optional? We could add an option on the Kconfig interface to choose between the old and this approach. |
a6e98b1
to
a56b80b
Compare
Couldn't get to this during the weekend. I've pushed a new commit with a kconfig symbol in the appropriate area. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've leaved a couple of minor comments, please let me know if they make sense to you, if so, please confirm they work as expected.
…condition for dependencies.
Added changes based on latest feedback. |
Awesome. Thank you, this is a big help! |
Thanks for the improvement @rashedtalukder , I've also included it in the development branch of this repo. |
For applications that might want to read the touch values without creating another task that is also reading the FT6336U over the i2c bus. This is especially an issue for the M5Stack Core2 for AWS IoT EduKit or standard Core2 that has etched buttons and touch sensing capabilities that are past the bounds of the screen perimeter.
Queue was chosen due to their minimal overhead and non-blocking. Directly copied the values to the queue instead of a pointer since the struct size is fairly small.
Example Usage: