GPIO display reset optional / Added M5Core2 / White space fixes #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to not allocate a GPIO for display reset: some may have that pin tied or attached to a Power management IC. Supersedes PR from @usedbytes doing same but only for IL9341, this is for all supported displays.
Many code editors are set to do this automatically now, so it ends up being annoying to scrape back out of commits to keep them easily reviewable. Also added '.DS_Store' and 'build' entries to .gitignore
|
Thanks. Although I'm not deep into this repo but the changes look good so I merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three separate commits in one PR:
LV_DISP_USE_RSTThis is the same fix as @usedbytes has made here before, making the use of a GPIO pin for reset optional. Some people have the reset tied, or have it hooked up to a pin of a power management IC. No need to waste a GPIO.
@usedbytes's fix is only implemented the Kconfig option in the IL9341 driver, this one is implemented in all drivers where there's a GPIO for reset.
LV_PREDEFINED_DISPLAY_M5CORE2Added support for the M5Core2. This depends on the previous, because it is setting
CONFIG_LV_DISP_USE_RST=nWhite space
I used a separate commit to remove white space at EOL and added some EOLs at EOF where needed. People's code editors are often set to do this automatically and it can make commits where they don't belong hard to audit. Also added a few entries to .gitignore.