Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new character encoding/decoding #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

new character encoding/decoding #35

wants to merge 2 commits into from

Conversation

mohammadkolahdouzan
Copy link
Contributor

This PR includes:

  • Removed all old style encodings/decodings (i.e., String.getBytes())
  • Added CharsetEncoder/Decoder for all encoding and decoding operations
  • Added support for a memory pool to be used for all encoding/decoding operations.
  • Removed support for all encodings except utf-8

mohammadkolahdouzan
mohammadkolahdouzan reviewed Jan 29, 2016
View reviewed changes
src/main/java/org/lwes/ArrayEvent.java
try {
final byte[] oldBytes = oldName.getBytes(defaultEncodingString);
final byte[] newBytes = name.getBytes(defaultEncodingString);
if (oldBytes != newBytes) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did this check ever work before?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djnym djnym djnym left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohammadkolahdouzan @djnym @nimaco