luca/makefile-improvements #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a CROSS_COMPILE value that contains a whitespace, such as "ccache arm-linux-", building fails because only the first word is passed down to the kernel Makefile as CROSS_COMPILE. Successive words are interpreted as targets. Fix by quoting CROSS_COMPILE. Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Allows to cleanly install the module in the standard way, as suggested by Documentation/kbuild/modules.txt in the kernel sources. This is needed when installing from within a build system (such as Buildroot) that implement depmod on its own, and does not need the blacklist and other fixups that are implemented by the 'install' target. Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
When installing using the modules_install target, the firmware is not installed. Add an ad-hoc target that just installs the firmware into $(INSTALL_MOD_PATH)/lib/firmware/rtlwifi/. Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Now there is a specific target to install the firmware, use it everywhere. Note: this does not change the behaviour if INSTALL_MOD_PATH is undefined. Otherwise the firmware is now installed under the INSTALL_MOD_PATH prefix. Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
The firmware is already installed in /lib/firmware/rtlwifi, no need to install it also in /lib/firmware. Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
ottagroup
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Larry,
here are a few cleanups and additions to Makefile.
I'm integrating rtl8188eu in Buildroot, for use on embedded systems with old kernels that have no mainline driver. But the 'install' target is specifically tailored for native building and installing, so I had to add a new 'modules_install' target that nicely integrate with a build system.
Patches are roughly in order from those that I believe to be "obviously OK" to those for which you might have comments, change requests or simply rejects.