Update Makefile to not error if repo was cloned using Sapling #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the `test` Makefile target conditional to pass for Sapling cloned repos. I was building this locally and ran into this issue because I cloned the repo using Sapling (https://sapling-scm.com) which uses a `.sl` directory at the repo root as opposed to a `.git` directory, and as such got the error message about zip files. Getting around the message was just making an empty top level `.git` directory, but IMO it shouldn't show this error in the first place. As of now, this would also fail with for Mercurial cloned repos (which uses a `.hg` directory). I thought of generalizing it to check for any hidden top level directory, but technically `.git` can be a can be a text file (see: https://git-scm.com/docs/gitrepository-layout) Also, I opted to not change the message printed in the failure case to include this as it might cause more confusion than benefit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
testMakefile target conditional to pass for Sapling cloned repos.I was building this locally and got the error message about zip files because I cloned the repo using Sapling (https://sapling-scm.com) which uses a
.sldirectory at the repo root as opposed to a.gitdirectory. Getting around the message was just making an empty top level.gitdirectory, but IMO it shouldn't show this error in this case.As of now, this would also fail with for Mercurial cloned repos (which uses a
.hgdirectory). I thought of generalizing it to check for any hidden top level directory, but technically.gitcan be a can be a text file (see: https://git-scm.com/docs/gitrepository-layout), so didn't go that route.Also, I opted to not change the message printed in the failure case to mention Sapling or .sl as it might cause more confusion than benefit.