Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v8 deprecation warnings #110

Merged
merged 2 commits into from
Apr 10, 2019
Merged

Fix v8 deprecation warnings #110

merged 2 commits into from
Apr 10, 2019

Conversation

bmcbarron
Copy link
Contributor

Migrate v8 and Nan deprecated methods to newer equivalents.
Eliminate extra buffer copy in Async_CaptureCb.

@Sija Sija requested review from catesq and lwille February 7, 2019 16:33
Copy link
Owner

@lwille lwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@lwille lwille merged commit 7e81740 into lwille:master Apr 10, 2019
@bmcbarron bmcbarron deleted the deprecated branch January 12, 2020 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants