Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTL comments appear incorrectly #26

Closed
yaronf opened this issue May 14, 2014 · 1 comment
Closed

RTL comments appear incorrectly #26

yaronf opened this issue May 14, 2014 · 1 comment
Assignees
@lwindolf
Labels
bug
Milestone
1.10.10

Comments

@yaronf
Copy link

yaronf commented May 14, 2014

While feeds and items have a correct dir attribute, comments still do not. So all the Hebrew comments for Hebrew articles are currently flush left.

The fix is simple (sorry for not providing proper patch):

In xslt/item.xml.in, line 394:

   <div class="comment" dir="{$txtDirection}">

Thanks!
@lwindolf lwindolf added the bug label May 14, 2014
@lwindolf lwindolf added this to the 1.10.10 milestone May 14, 2014
@lwindolf lwindolf self-assigned this May 14, 2014
lwindolf added a commit that referenced this issue May 14, 2014
@lwindolf
Fixes Github #26: RTL comments appear incorrectly (reported by yaronf)
ef2e5be
@lwindolf
Copy link
Owner

Thanks for the hint! Fix will be released with 1.10.10 and 1.11.0

lwindolf added a commit that referenced this issue May 15, 2014
@lwindolf
Fixes Github #26: RTL comments appear incorrectly (reported by yaronf)
76ac9f9
@ndias ndias mentioned this issue Aug 26, 2014
Closed
@jcamposz jcamposz mentioned this issue Feb 20, 2015
Closed
@gabrielesvelto gabrielesvelto mentioned this issue Apr 8, 2016
Closed
@paulgevers paulgevers mentioned this issue Mar 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lwindolf lwindolf

Labels
bug
Projects
None yet
Milestone
1.10.10
Development

No branches or pull requests
2 participants
@yaronf @lwindolf