Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestClient.request() method does not have a data_type argument like the real client #239

Open
roblight opened this issue Sep 27, 2022 · 3 comments
Assignees

Comments

@roblight
Copy link

Here's what I quickly came up with:

master...roblight:panini:master

The following tests are failing and I have not looked into why yet:

tests/test_diff_datatypes.py::test_listen_bytes FAILED  [  6%]
tests/test_diff_datatypes.py::test_publish_str FAILED   [  8%]
tests/test_diff_datatypes.py::test_publish_bytes FAILED [  9%]
tests/test_diff_datatypes.py::test_request_str FAILED   [ 12%]
tests/test_diff_datatypes.py::test_request_bytes FAILED [ 13%]

It would be great if someone with more knowledge of this project could add this argument! 😄

@roblight
Copy link
Author

Related to #238

@artas728
Copy link
Collaborator

artas728 commented Oct 1, 2022

Indeed, need to be fixed. We will think about the best way to do this.

@artas728 artas728 self-assigned this Oct 1, 2022
artas728 pushed a commit that referenced this issue Nov 21, 2022
@artas728
Copy link
Collaborator

Same as for #238. It's fixed for v0.8.0a1. It'll take some time before the release of v0.8.0.

But looking ahead, I'm not sure we'll continue to support an additional test client for a long. We are thinking about a way to use Panini itself as a test client for integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants