Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a balanced option for limits.cpu.nodes #570

Closed
stgraber opened this issue Mar 1, 2024 · 1 comment
Closed

Add a balanced option for limits.cpu.nodes #570

stgraber opened this issue Mar 1, 2024 · 1 comment
Assignees
Labels
Easy Good for new contributors
Milestone

Comments

@stgraber
Copy link
Member

stgraber commented Mar 1, 2024

Introduce a new option to limits.cpu.nodes to allow for balancing between NUMA nodes.

This would affect both containers and virtual machines and would basically look at all NUMA nodes on the system on instance startup, pick whichever currently has the lowest usage, store that in a volatile key and then use it as the actual limits.cpu.nodes value within the rest of our logic.

We can refine the logic to identify the least used NUMA node down the line.
Initially we can keep this pretty simple by just mapping out how many instances CPUs are allocated to each node. We'd treat any case where limits.cpu is empty to mean 1 CPU for simplicity.

@stgraber stgraber added Feature Easy Good for new contributors labels Mar 1, 2024
@stgraber stgraber added this to the incus-0.7 milestone Mar 8, 2024
@stgraber stgraber self-assigned this Mar 21, 2024
@stgraber
Copy link
Member Author

Looking into that one now.

stgraber added a commit to stgraber/incus that referenced this issue Mar 22, 2024
Closes lxc#570

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
stgraber added a commit to stgraber/incus that referenced this issue Mar 22, 2024
Closes lxc#570

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
@hallyn hallyn closed this as completed in 334ca4d Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy Good for new contributors
Development

No branches or pull requests

1 participant