Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incus-simplestreams remove does not remove combined images #994

Closed
melato opened this issue Jul 14, 2024 · 1 comment · Fixed by #995
Closed

incus-simplestreams remove does not remove combined images #994

melato opened this issue Jul 14, 2024 · 1 comment · Fixed by #995
Assignees
@melato
Labels
Easy Good for new contributors
Milestone
incus-6.4

Comments

@melato
Copy link
Contributor

melato commented Jul 14, 2024

Required information

  • Version: incus 6.3, incus-extra

Issue description

Steps to reproduce

  1. publishing a container and export the image to an image.tar.gz file somewhere
  2. create an empty simplestreams directory and cd to it.
  3. incus-simplestreams add {path-to-image.tar.gz above}
  4. incus-simplestreams list # you should see the image and its fingerprint
  5. incus-simplestreams remove {fingerprint}
  6. incus-simplestreams list

Result: The image shows up in the list
Expected Result: The image should have been deleted and removed from the list
@melato
Copy link
Contributor Author

melato commented Jul 14, 2024

incus/cmd/incus-simplestreams/main_remove.go looks for a product version item of the type "incus.tar.xz".
But a combined image has type "incus_combined.tar.gz", and is therefore not deleted.
I will provide a pull request with a fix, shortly.

melato added a commit to melato/incus that referenced this issue Jul 14, 2024
@melato
fixed incus-simplestream remove not removing combined tarball image. #f…
0e6ac7d 
…ixes lxc#994.

added --verbose flag to print deleted files

Signed-off-by: Alex Athanasopoulos <alex@melato.org>
@melato melato mentioned this issue Jul 14, 2024
Merged
@stgraber stgraber added this to the incus-6.4 milestone Jul 15, 2024
@stgraber stgraber added Bug Easy Good for new contributors labels Jul 15, 2024
stgraber pushed a commit that referenced this issue Jul 18, 2024
@melato @stgraber
incus-simplestreams: Handle removal of combined images
66cf67c 
Also adds --verbose flag to print deleted files

Closes #994

Signed-off-by: Alex Athanasopoulos <alex@melato.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melato melato

Labels
Easy Good for new contributors
Milestone
incus-6.4
Development

Successfully merging a pull request may close this issue.

incus-simplestreams: Handle removal of combined images melato/incus
2 participants
@melato @stgraber