incusd/internal/server/instance/drivers: support for Chimera Linux (qemu/edk2) pkg layout #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS, once approved, I can do a PR for https://linuxcontainers.org/incus/docs/main/installing/ but will provide the docs here too. I'd prefer holding off submitting a PR for install docs because this particular PR is key to making Incus properly functional without manual workarounds on Chimera Linux. Install: To install Incus on Chimera Linux, ensure the Then add the To run virtual machines, also add the EDK2 firmware. Chimera Linux currently does not provide complete support for Secure Boot, so virtual machines must be launched with this feature disabled. Report packaging issues here. |
hallyn
approved these changes
Oct 11, 2024
|
Thanks, looks good to me. I do have to ask though - what would be the chances of just having the incus package in chimera linux add symlinks to the names incus already knows them by? Also, I wonder if we should start adding comments to each line to say which distros they are intended to support |
|
Interesting, SOB check wants the same username that shows up in From. I didn't know it checked for that... |
|
On Fri, 2024-10-11 at 12:32 -0700, Serge Hallyn wrote:
Thanks, looks good to me.
I do have to ask though - what would be the chances of just having
the incus package in chimera linux add symlinks to the names incus
already knows them by?
Indeed, that's what I had been doing, manually. I rationalized
submitting these changes as Chimera Linux maintainers have used the
package/filenames/descriptors from the qemu package, so at least they
will match if other distributions have or will follow suit.
https://github.com/qemu/qemu/tree/05adb38839ba656c7383a548b460d95c91e2febe/pc-bios
Also, I wonder if we should start adding comments to each line to say
which distros they are intended to support
Seems like a good idea; after looking at Ubuntu/Debian, Fedora, Arch
and openSUSE (which should package Incus but doesn't to my
disappointment) they are all rather unique combos of paths and EDK2
filenames.
|
What's the right way to correct this? Both email addresses are deliverable to me, btw; since this I had github verify the github@. I'll ensure I've used git@mike... in the future, the commit comment was a typo on my part. |
Oh, that seems reasonable. |
Well the easiest way for you is probably to just make the SOB line be Signed-off-by: Mike Watkins git@mikewatkins.ca Rather than do a git commit --amend --author=...github... |
mwyvr
force-pushed
the
incusd-edk2-chimera
branch
from
cca6fec
to
1c64a0b
Compare
mwyvr
changed the title
stgraber
approved these changes
Oct 20, 2024
…x edk2 pkg file names Signed-off-by: Mike Watkins <git@mikewatkins.ca>
stgraber
force-pushed
the
incusd-edk2-chimera
branch
from
1c64a0b
to
ea58dac
Compare
|
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Nov 22, 2024
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [lxc/incus](https://github.com/lxc/incus) | minor | `v6.6.0` -> `v6.7.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>lxc/incus (lxc/incus)</summary> ### [`v6.7.0`](https://github.com/lxc/incus/releases/tag/v6.7.0): Incus 6.7 [Compare Source](lxc/incus@v6.6.0...v6.7.0) #### What's Changed - fix live update VM's limits.memory configuration when use a percentage value by [@​itviewer](https://github.com/itviewer) in lxc/incus#1287 - fix: fix slice init length by [@​cuishuang](https://github.com/cuishuang) in lxc/incus#1285 - incusd/instance/lxc: Remove restrictions on /run by [@​stgraber](https://github.com/stgraber) in lxc/incus#1288 - Correct macvlan mode names by [@​stgraber](https://github.com/stgraber) in lxc/incus#1284 - Translations update from Hosted Weblate by [@​weblate](https://github.com/weblate) in lxc/incus#1290 - Translations update from Hosted Weblate by [@​weblate](https://github.com/weblate) in lxc/incus#1295 - Translations update from Hosted Weblate by [@​weblate](https://github.com/weblate) in lxc/incus#1304 - incus-simplestreams: Fix list -f json by [@​melato](https://github.com/melato) in lxc/incus#1310 - Profile performance improvements by [@​stgraber](https://github.com/stgraber) in lxc/incus#1314 - incus-agent: Add timeout for DNS query by [@​stgraber](https://github.com/stgraber) in lxc/incus#1313 - incusd/instance/qemu: Don't fail on console retrival issue by [@​stgraber](https://github.com/stgraber) in lxc/incus#1316 - Allow changing the parent value on physical networks by [@​stgraber](https://github.com/stgraber) in lxc/incus#1317 - incus: Fix display of current project in projects list by [@​montag451](https://github.com/montag451) in lxc/incus#1318 - Add `--format` to `incus admin sql` by [@​stgraber](https://github.com/stgraber) in lxc/incus#1319 - incusd/internal/server/instance/drivers: support for Chimera Linux (qemu/edk2) pkg layout by [@​mwyvr](https://github.com/mwyvr) in lxc/incus#1298 - incusd/instance/common: Cleanup volatile on device add failure by [@​stgraber](https://github.com/stgraber) in lxc/incus#1323 - incusd/network/bgp: Only advertise networks with BGP configuration by [@​stgraber](https://github.com/stgraber) in lxc/incus#1325 - Make revert library shared by [@​gibmat](https://github.com/gibmat) in lxc/incus#1326 - Fix to the cluster resources caching mechanism by [@​stgraber](https://github.com/stgraber) in lxc/incus#1324 - Fix idmap issues by [@​stgraber](https://github.com/stgraber) in lxc/incus#1327 - Make ask library shared by [@​gibmat](https://github.com/gibmat) in lxc/incus#1329 - doc/network/resolved: Add disabling DNSSEC and DNSOverTLS by [@​ntnn](https://github.com/ntnn) in lxc/incus#1328 - Add some application container documentation by [@​stgraber](https://github.com/stgraber) in lxc/incus#1331 - incusd/device/nic/bridged: Handle invalid configuration by [@​stgraber](https://github.com/stgraber) in lxc/incus#1330 - Fix handling of custom volume snapshot patterns by [@​stgraber](https://github.com/stgraber) in lxc/incus#1333 - Add OCI DHCP renewal by [@​stgraber](https://github.com/stgraber) in lxc/incus#1334 - doc/installing: Update for Chimera Linux by [@​mwyvr](https://github.com/mwyvr) in lxc/incus#1335 - shared/cgo: Don't use strlcpy by [@​stgraber](https://github.com/stgraber) in lxc/incus#1337 - Implement `incus webui` by [@​stgraber](https://github.com/stgraber) in lxc/incus#1338 - incusd/scriptlet: Make set_target fail with invalid members by [@​bensmrs](https://github.com/bensmrs) in lxc/incus#1339 - Export QMP functions by [@​bensmrs](https://github.com/bensmrs) in lxc/incus#1340 - incusd/network/ovn: Add support to ipv4.dhcp.ranges by [@​jonatas-lima](https://github.com/jonatas-lima) in lxc/incus#1341 - internal/server: Log QMP interaction to a file by [@​bensmrs](https://github.com/bensmrs) in lxc/incus#1345 - incusd/instance/qemu: Log QEMU command line by [@​bensmrs](https://github.com/bensmrs) in lxc/incus#1346 - Improve cluster instance placement by [@​stgraber](https://github.com/stgraber) in lxc/incus#1344 - incusd/instance_logs: Update log file list by [@​stgraber](https://github.com/stgraber) in lxc/incus#1347 - Add infrastructure for OVN events by [@​stgraber](https://github.com/stgraber) in lxc/incus#1349 - Fix QEMU feature checks during startup by [@​stgraber](https://github.com/stgraber) in lxc/incus#1350 - incusd/instance/lxc: Fix LXCFS per-instance path by [@​stgraber](https://github.com/stgraber) in lxc/incus#1352 - doc/idmap: Clarify subuid/subgid configuration by [@​stgraber](https://github.com/stgraber) in lxc/incus#1353 - incusd/instance/qmp: Fix logging with no log file by [@​stgraber](https://github.com/stgraber) in lxc/incus#1355 - Add a GetOIDCTokens() method by [@​gibmat](https://github.com/gibmat) in lxc/incus#1357 - Add get-current to show current project by [@​maveonair](https://github.com/maveonair) in lxc/incus#1356 - incus/file/create: Use SFTP client instead of file API by [@​HassanAlsamahi](https://github.com/HassanAlsamahi) in lxc/incus#1354 - internal/instance: Allow 0 as value to limits.cpu.nodes by [@​stgraber](https://github.com/stgraber) in lxc/incus#1358 - Translations update from Hosted Weblate by [@​weblate](https://github.com/weblate) in lxc/incus#1361 - Translations update from Hosted Weblate by [@​weblate](https://github.com/weblate) in lxc/incus#1362 - Translations update from Hosted Weblate by [@​weblate](https://github.com/weblate) in lxc/incus#1368 - Improve agent interface listing performance by [@​stgraber](https://github.com/stgraber) in lxc/incus#1367 - Make `incus top` output configurable through options by [@​presztak](https://github.com/presztak) in lxc/incus#1370 - Automatic live-migration to balance load on cluster by [@​presztak](https://github.com/presztak) in lxc/incus#1369 - gomod: Update dependencies by [@​stgraber](https://github.com/stgraber) in lxc/incus#1372 - Add refresh-exclude-older flag to only transfer new snapshots during instance/volume refresh by [@​ps-gill](https://github.com/ps-gill) in lxc/incus#1365 - incusd/instances/publish: Fix base metadata by [@​stgraber](https://github.com/stgraber) in lxc/incus#1374 - Fix TPM with long instance names by [@​stgraber](https://github.com/stgraber) in lxc/incus#1377 - Don't BGP advertise OVN load-balancers when all backends are offline by [@​stgraber](https://github.com/stgraber) in lxc/incus#1376 - incusd/instance/qemu: Don't take over operations on console retrieval by [@​stgraber](https://github.com/stgraber) in lxc/incus#1379 - Tweak to cluster internal relocation by [@​stgraber](https://github.com/stgraber) in lxc/incus#1378 #### New Contributors - [@​cuishuang](https://github.com/cuishuang) made their first contribution in lxc/incus#1285 - [@​mwyvr](https://github.com/mwyvr) made their first contribution in lxc/incus#1298 - [@​ntnn](https://github.com/ntnn) made their first contribution in lxc/incus#1328 - [@​jonatas-lima](https://github.com/jonatas-lima) made their first contribution in lxc/incus#1341 **Full Changelog**: lxc/incus@v6.6.0...v6.7.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incus is packaged for Chimera Linux; this addition provides support for edk2 filenames as packaged by Chimera Linux (these are the base filenames supplied by the qemu/edk2 package https://github.com/qemu/edk2).
Have built and tested on x86_64 arch / Chimera Linux (musl libc); both containers and virtual machines (security.secureboot=false) perform as expected.