Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incusd/instance/qemu: Don't fail on console retrival issue #1316

Merged
merged 1 commit into from
Oct 17, 2024
Merged

incusd/instance/qemu: Don't fail on console retrival issue #1316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions internal/server/instance/drivers/driver_qemu.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4953,11 +4953,8 @@ func (d *qemu) Stop(stateful bool) error {
}
}

// Save the console log from ring buffer before the instance is stopped. Must be run prior to creating the operation lock.
_, err := d.ConsoleLog()
if err != nil {
return err
}
// Attempt to save the console log from ring buffer before the instance is stopped. Must be run prior to creating the operation lock.
_, _ = d.ConsoleLog()

// Setup a new operation.
// Allow inheriting of ongoing restart or restore operation (we are called from restartCommon and Restore).
Expand Down
Loading