Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci: Add local prefixes for goimports #1401

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

breml
Copy link
Collaborator

@breml breml commented Nov 20, 2024

No description provided.

@breml breml requested a review from stgraber as a code owner November 20, 2024 06:35
.golangci.yml Show resolved Hide resolved
@stgraber
Copy link
Member

@breml your commit is missing the Signed-off-by line

@stgraber stgraber added the Incomplete Waiting on more information from reporter label Nov 22, 2024
Signed-off-by: Lucas Bremgartner <lucas.bremgartner@futurfusion.io>
@breml
Copy link
Collaborator Author

breml commented Nov 26, 2024

@stgraber signoff should be there now, the PR still waits for an approval (even with auto-merge enabled).

@stgraber stgraber merged commit 95ac00c into lxc:main Nov 26, 2024
30 checks passed
@breml breml deleted the goimports-local-prefixes branch November 27, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Incomplete Waiting on more information from reporter
Development

Successfully merging this pull request may close these issues.

2 participants