Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import LXD changes #172

Merged
merged 30 commits into from
Oct 17, 2023
Merged

Import LXD changes #172

merged 30 commits into from
Oct 17, 2023

Conversation

stgraber
Copy link
Member

No description provided.

stgraber and others added 30 commits October 16, 2023 18:08
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Din Music <din.music@canonical.com>
Tests failing at:

```
  incus storage create incustest-5zO ceph volume.size=25MiB ceph.osd.pg_num=8
```

All seem to have `microceph.ceph status` show as:

```
 + sudo microceph.ceph status
  cluster:
    id:     7e42c215-815d-477f-afa9-5f218fcc3081
    health: HEALTH_WARN
            mon fv-az1234-656 is low on available space
            nobackfill,norebalance,norecover,noscrub,nodeep-scrub,nosnaptrim flag(s) set
            3 pool(s) have no replicas configured
            OSD count 0 < osd_pool_default_size 1

  services:
    mon: 1 daemons, quorum fv-az1234-656 (age 63s)
    mgr: fv-az1234-656(active, since 55s)
    mds: 1/1 daemons up
    osd: 0 osds: 0 up, 0 in
         flags nobackfill,norebalance,norecover,noscrub,nodeep-scrub,nosnaptrim

  data:
    volumes: 1/1 healthy
    pools:   3 pools, 65 pgs
    objects: 0 objects, 0 B
    usage:   0 B used, 0 B / 0 B avail
    pgs:     100.000% pgs unknown
             65 unknown
```

Poll `ceph pg stat` for up to a minute to stabilize and no longer have unknown pgs.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
ceph's mon was complaining about low free space in the
rootfs.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
…ally revert to events API.

Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
… MirrorRead

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…irror*()

The reason its unused is because its not a good idea to cancel the context
as you will potentially lose output written from the process.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…duces GetPollRevents

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…orRead() and ws.Mirror()

This wrapper is instantiated using NewExecWrapper() and it wrap an *os.File so
that it uses poll to check if there is something to read first to avoid blocking
reads. It uses a 1s timeout on poll so that if the context is cancelled any
outstanding Read() calls return within 1s.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…ncel

There's no benefit to the extra dependency here.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Fixes #12210

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
… line with container exec

Fixes #12210

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
@github-actions github-actions bot added Documentation Documentation needs updating API Changes to the REST API labels Oct 16, 2023
@brauner brauner merged commit 16595fe into lxc:main Oct 17, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Changes to the REST API Documentation Documentation needs updating
Development

Successfully merging this pull request may close these issues.

7 participants