Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxd-to-incus: query systemd instead of assuming service file path #201

Merged
merged 1 commit into from
Oct 28, 2023
Merged

lxd-to-incus: query systemd instead of assuming service file path #201

merged 1 commit into from
Oct 28, 2023

Conversation

adamcstephens
Copy link
Contributor

systemd supports multiple paths, so rely on its detection logic instead of checking a specific path.

@stgraber
Copy link
Member

Commit isn't signed-off, please make sure the commit message includes the Signed-off-by: Firstname Lastname <email> line.

@adamcstephens
Copy link
Contributor Author

Fixed.

@stgraber
Copy link
Member

 Checking for oneline assign & test...
cmd/lxd-to-incus/targets.go:28:	if _, err := subprocess.RunCommand("systemctl", "list-unit-files", "incus.service"); err != nil {

Our code style doesn't allow for one-line define+check syntax, so you'll need to update that to be two lines instead.

Signed-off-by: Adam Stephens <adam@valkor.net>
@adamcstephens
Copy link
Contributor Author

adamcstephens commented Oct 27, 2023

Fixed. I wish github would allow workflows on a PR that has already been approved to run them. :(

I missed the 0.2 release so we'll carry this as a patch for NixOS.

@stgraber
Copy link
Member

Yeah, we have the setting on Github Actions to require an initial approval for a new contributor which is fine, except that Github apparently requires it for every change in that initial PR...

@stgraber stgraber merged commit 1d7f274 into lxc:main Oct 28, 2023
25 checks passed
@adamcstephens adamcstephens deleted the migrate/fix-systemd branch October 28, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants