incusd/cluster: Ensure the cluster member config is always sorted #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The database functions return maps which are inherently unsorted, this then would turn the MemberConfig slice under a similarly unsorted slice.. That's a problem because our own CLI and some 3rd party tools will ask the user to answer each of the MemberConfig questions during join. The user may assume that when joining multiple systems, the questions will be in the same order on all systems, when they're not, they may incorrectly answer some of the questions. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
stgraber
changed the title
freeekanayaka
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The database functions return maps which are inherently unsorted, this then would turn the MemberConfig slice under a similarly unsorted slice..
That's a problem because our own CLI and some 3rd party tools will ask the user to answer each of the MemberConfig questions during join.
The user may assume that when joining multiple systems, the questions will be in the same order on all systems, when they're not, they may incorrectly answer some of the questions.