Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual update to French translation and doc fixes #391

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

smCloudInTheSky
Copy link
Contributor

Hi !

I've discovered recently (thanks to phoronix) this amazing tool !
I wanted to start contributing and since I'm french I wanted to start by looking at the french translation. It seemed incomplete so I'm opening already the MR to have an initial review of what I have done and then continue until I've at least done most of the lines.

I've corrected some things that seemed incoherent with the english source.

@smCloudInTheSky smCloudInTheSky marked this pull request as draft January 15, 2024 21:40
@smCloudInTheSky smCloudInTheSky changed the title Translation : improve french translation WIP Translation : improve french translation Jan 15, 2024
@stgraber
Copy link
Member

Thanks!

I haven't yet had the time to sort out the translation flow for Incus on Weblate but I'll do that hopefully later today and then upload your translations to the French language there.

After that you should be able to do further translations through Weblate directly which will then automatically flow into our releases.

@stgraber
Copy link
Member

@smCloudInTheSky can you try accessing https://hosted.weblate.org/projects/incus/cli/ and see if you're able to translate Incus through it?

@smCloudInTheSky
Copy link
Contributor Author

Yes it works ! So now I can continue on weblate and it will automatically be merged to the project ?
If so I can drop my commit about translation and just keep the documentation part and add something about Weblate then ?

@stgraber
Copy link
Member

Yeah, changes done in Weblate will automatically be pushed to this repo every few days.

@smCloudInTheSky
Copy link
Contributor Author

Would it be possible to merge my changes before ? Or do I have to redo all the modifications I did on the fr file ?

Signed-off-by: Sylvain Maret <sylvain.maret@hotmail.fr>
Signed-off-by: Sylvain Maret <sylvain.maret@hotmail.fr>
Signed-off-by: Sylvain Maret <sylvain.maret@hotmail.fr>
@stgraber stgraber marked this pull request as ready for review January 16, 2024 20:41
@stgraber
Copy link
Member

I've done some minor commit message updates and this is now going through tests.
Once things look good, I'll merge it and Weblate will import the new changes, after that further updates can be done through Weblate.

@stgraber stgraber changed the title WIP Translation : improve french translation Manual update to French translation and doc fixes Jan 16, 2024
@smCloudInTheSky
Copy link
Contributor Author

Thanks !
I'll get some advice to continue from people who does translation as a job in the meantime !

@stgraber stgraber merged commit a4bc281 into lxc:main Jan 16, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants