Change incus-agent install location to writeable location #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, It looks like your commit is missing the expected Signed-off-by line. In general I'd still prefer we attempt to install to /lib/systemd and then fallback to /etc/systemd if we can't. That's for two reasons:
|
|
I apologize for the missing sign-off. I'll add some logic to fallback to /etc. |
|
No worries, thanks for your work! |
stgraber
approved these changes
May 22, 2024
This changes the default agent install location to /usr/lib/ with fallback to /lib/ and eventually /etc/, therefore supporting immutable systems where only /etc is writable. Signed-off-by: m2 <69128853+m2Giles@users.noreply.github.com> Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the install script for incus agent attempts to install to
/lib. This changes it to write to/etcinstead. Many systems mount/usrread-only and/libis usually a symlink to/usr/lib./etc/is normally a writable location on all systems.