Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incus/storage: Add customizable columns in list #842

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

trannlong
Copy link
Contributor

Added customizable columns to incus storage list
This solves issue #718
Signed-off-by: Long Tranlongtran@utexas.edu

@trannlong trannlong requested a review from stgraber as a code owner May 6, 2024 14:00
trannlong and others added 2 commits May 6, 2024 10:38
Closes lxc#718

Signed-off-by: Long Tran <longtran@utexas.edu>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
@stgraber
Copy link
Member

stgraber commented May 6, 2024

Sorted this one out:

  • Fixed help message indent
  • Ran make static-analysis and fixed what it picked up
  • Generate an i18n commit with make i18n
  • Changed column list to match existing order
  • Fixed incorrect d/D column (swapped)
  • Fixed driver, source, state and usedBy columns to actually return the correct data

@stgraber stgraber changed the title Added customizable column to incus storage list incus/storage: Add customizable columns in list May 6, 2024
@trannlong
Copy link
Contributor Author

Sorry, will do the additional steps for issue #719 as well, as we've finished the issue in our group.

@stgraber stgraber merged commit f7ebfc8 into lxc:main May 6, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants