Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incus/storage_volume/snapshot: Support YAML for creation #891

Merged
merged 2 commits into from
May 23, 2024
Merged

incus/storage_volume/snapshot: Support YAML for creation #891

merged 2 commits into from
May 23, 2024

Conversation

stgraber
Copy link
Member

Closes #741

@stgraber stgraber mentioned this pull request May 23, 2024
Closed
17 tasks
@stgraber
incus/storage_volume/snapshot: Support YAML for creation
6f4cf45 
Closes lxc#741

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
@stgraber
i18n: Update translation templates
b2f8b44 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
hallyn
hallyn approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@hallyn hallyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine so long as you intend for the stdinData.Description to be ignored.

@stgraber
Copy link
Member Author

@hallyn I think that StorageVolumeSnapshot having an editable Description is actually a bug, the description should be read-only and come from the original volume at the time it was snapshotted (same as instances).

@hallyn hallyn merged commit 9d02f1c into lxc:main May 23, 2024
25 checks passed
@gabrielmougard gabrielmougard mentioned this pull request Aug 28, 2024
Merged
tomponline added a commit to canonical/lxd that referenced this pull request Sep 3, 2024
@tomponline
lxc: allow creation of various resources from YAML (from Incus) (#13995)
495e793 
cherry-picked from: lxc/incus#786
cherry-picked from: lxc/incus#782
cherry-picked from: lxc/incus#778
cherry-picked from: lxc/incus#775
cherry-picked from: lxc/incus#767
cherry-picked from: lxc/incus#863
cherry-picked from: lxc/incus#864
cherry-picked from: lxc/incus#891
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hallyn hallyn hallyn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to read YAML from stdin to all create commands
2 participants
@stgraber @hallyn