proc_loadavg.c: Fix incompatible integer to pointer conversion #610
Conversation
Newer compiler like Clang 16 and GCC 14 have certain error enabled by default, namely -Werror=incompatible-function-pointer-types. Which resutls in build error such as: proc_loadavg.c:606:10: error: incompatible integer to pointer conversion returning int from a function with result type pthread_t My patch supresses the error for now, but a proper fix would be better. Fist discovered on Gentoo linux (bug #894348). Bug: https://bugs.gentoo.org/894348 Closes: lxc#561 Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
|
@brauner @mihalicyn what do you think we should do to clean that up properly? |
|
Ugh, strictly speaking we can't rely on the fact that IMHO this fix is good enough to be merged to make our Gentoo friends happy. But I have to rework that and add and export a new liblxcfs function like Christian? |
Hey! Just wanted to note that it's not just Gentoo, rather all new compiler (as I mentioned GCC14 and Clang 16). :) |
haha, sure! But Gentoo of course the first in the line of distros in terms of having a new versions of compilers and stuff (and Fedora?) ;-) |
Cleanup start_loadavg code: - add a new external symbol load_daemon_v2 with the pthread_create-like signature - make hacky casts of pthread_t to int (and reverse) unnecessary for new API users Related to: lxc#610 Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
Newer compiler like Clang 16 and GCC 14 have certain error enabled by default, namely -Werror=incompatible-function-pointer-types. Which resutls in build error such as:
My patch supresses the error for now, but a proper fix would be better. Fist discovered on Gentoo linux (bug #894348).
Bug: https://bugs.gentoo.org/894348
Closes: #561