-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unmount encrypted external drive impossible from plugin-mount menu #1639
Comments
Just wanted to say that pcmanfm-qt (actually, libfm-qt) and plugin-mount have totally different methods for it: the former uses GLib/GIO while the latter makes use of |
This is still annoying. Will check in a plasma session if there's something working, not sure if there is an applet on the panel. |
Because nothing has changed ;) I'd use only pcmanfm-qt for such jobs. |
Just out of curiosity I had a look in the implementation… Tsujan is fully correct here. The plugin itself simply ignores LXQt's (existing) device management approach (-> pcmanfm-qt). Let me prepare something… |
LXQt is modular and can be used without pcmanfm-qt/libfm-qt. lxqt-panel isn't and shouldn't be dependent on libfm-qt, and vice versa. |
Sure lxqt-panel is (conceptually) broken in many ways… What do you suggest!? |
I don't know what you're talking about.
Like in other places. If the bug is in the code, it should be fixed. If it's in In short, someone needs to look into the current code, not to dismiss it altogether. |
(As written earlier) I actually had a look in the code (exactly here). Although the "architecture" is very spaghetty 🍝 it is unlikely a bug in the lxqt-panel code since the specific scenario can be observed only on encrypted devices. (Spaghetti fixing is not for me anymore… 🤣) |
@stefonarch More details:
So, I don't think we can do anything about this. GLib/GIO is simply superior to |
I connected the device, ignored the popup and used the button on the panel, first it asked me the passwd for kwalletd6, then the passwd for the disk. I remember kwallet to be complicated as many other things in KDE. panel6.mp4 |
Nothing about KWallet here, but that's beside the point. Even if the encrypted volume is mounted by pcmanfm-qt, restarting of Panel makes the Removable Media plugin see the mounted volume and enable its eject button. The bug is that no |
There's no way to fake/send such a signal? |
No, but there may be a workaround: to update the mount state every time the popup is shown. I'll make a patch. |
`Solid::StorageAccess::accessibilityChanged` isn't emitted when an encrypted volume is mounted by GLib/GIO (e.g., through pcmanfm-qt). This is a workaround. Closes #1639
`Solid::StorageAccess::accessibilityChanged` isn't emitted when an encrypted volume is mounted by GLib/GIO (e.g., through pcmanfm-qt). This is a workaround. Closes #1639
Clicking on the eject button in the popup menu from plugin-mount does nothing when usb drive is encrypted.
Unmount in pcmanfm-qt sidebar works as expected.
Expected Behavior
Unmount encrypted drive from panel works.
Current Behavior
It does nothing.
Steps to Reproduce (for bugs)
System Information
The text was updated successfully, but these errors were encountered: