Wayfire taskbar backend #2071
Closed
Wayfire taskbar backend #2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an abstract interface to operate windows and workspaces
- Move WindowProperty enum to lxqttaskbartypes.h
This model will manage the tasks shown
Also use it to get window icon
- Don't rely on global screen coordinates - This will be needed for future Wayland port, Where we don't have global screen coordinates - Keep compatible behavior on X11
This new window propery flag is needed to notify geometry changes
- It is now a global instance
This will be used to avoid crashing panel in case no backend could be created. A warning message will be printed in this case.
NOTE: works only on KWin - Choose backend at runtime - Windows filter logic is re-evaluated on window property changes
TODO: is this correct? Seems to call wl_proxy_destroy underneath
…TODO TODO: is this correct approach?
NOTE: absolute path is needed inside .desktop file for this to work
use CMake to get it.
- Prevent double dekstop file installed in autostart
- reloadWindows() force removal and readding of windows This fixes changing windows grouping settings and adding taskbar plugin AFTER panel is started. Both situations resulted in empty taskbar previously
TODO: show error message when not supported
- Add NoDisplay=true to .desktop file
|
Hi @marcusbritanicus. |
|
@gfgit Well... I will not be starting for a while now. This just so that we can get some discussions going. I'll rebase later. Currently, I have rebased #2046 on master, and this one is on top of that. If things go as I hope they will (the modules approach), then quite a few changes will be done. So I'll wait for other things for the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a taskbar backend for when the panel is running as a Wayfire client.
TODO:
This PR requires a few discussions before I can begin work. The output management and the hence the corresponding window and workspace management on wayfire is different from Plasma. This may require a slightly different approach on our part while dealing with the UI.