Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyqt: move to SIP 5.x #465

Merged
merged 1 commit into from
Mar 12, 2022
Merged

pyqt: move to SIP 5.x #465

merged 1 commit into from
Mar 12, 2022

Conversation

yan12125
Copy link
Member

@yan12125 yan12125 commented Mar 6, 2022

SIP 4.x is no longer supported [1].

And drop CMake integration for PyQt bindings - it's too messy for SIP
5.x

[1] https://www.riverbankcomputing.com/software/sip/download

pyqt: move to SIP 5.x
9696f3d 
SIP 4.x is no longer supported [1].

And drop CMake integration for PyQt bindings - it's too messy for SIP
5.x

[1] https://www.riverbankcomputing.com/software/sip/download
@yan12125
Copy link
Member Author

yan12125 commented Mar 6, 2022

@tsujan some notes about releases:

  • This PR should be merged before the next qtermwidget release. Arch has upgraded PyQt5 to a version incompatible with SIP 4.x. As a result SIP 5.x is necessary to build PyQt bindings.
  • The version in pyqt/pyproject.toml should be kept in sync with the version in CMakeLists.txt

@yan12125 yan12125 mentioned this pull request Mar 6, 2022
Open
@tsujan
Copy link
Member

tsujan commented Mar 6, 2022 •
edited
Loading

@yan12125, I have no knowledge in this area. Would you please merge it yourself?

The version in pyqt/pyproject.toml should be kept in sync with the version in CMakeLists.txt

Please make the required changes if they aren't related to QTERMWIDGET_VERSION_MAJOR, QTERMWIDGET_VERSION_MINOR and QTERMWIDGET_VERSION_PATCH — I'll set them when releasing LXQt 1.1.0.

@tsujan
Copy link
Member

tsujan commented Mar 6, 2022

Oh, you mean version = "1.0.0" in the new pyqt/pyproject.toml. OK, I made a note for myself to not forget it. Thanks!

@yan12125
Copy link
Member Author

yan12125 commented Mar 6, 2022

I have no knowledge in this area. Would you please merge it yourself?

To be honest, I'm not familiar with PyQt either. I called for testing at #364 (comment). If nobody shows up and tests this, I will just merge it next weekend.

Oh, you mean version = "1.0.0" in the new pyqt/pyproject.toml

Yep :)

@yan12125 yan12125 merged commit 76b4e9f into master Mar 12, 2022
@yan12125 yan12125 deleted the sip5 branch March 12, 2022 03:02
@yan12125 yan12125 mentioned this pull request Mar 12, 2022
Closed
yan12125 pushed a commit to archlinuxcn/repo that referenced this pull request Mar 12, 2022
qtermwidget-git: switch to SIP 5.x following upstream
3732121 
See: lxqt/qtermwidget#465

Also drops update_aur_repo() - it's not that useful as commit messages
are not passed through
archlinux-github pushed a commit to archlinux/aur that referenced this pull request Jul 31, 2022
switch to SIP 5.x following upstream
40c5f3b 
See: lxqt/qtermwidget#465
inventor2525 pushed a commit to inventor2525/qtermwidget that referenced this pull request May 14, 2024
pyqt: move to SIP 5.x (lxqt#465)
dc01cef 
SIP 4.x is no longer supported [1].

And drop CMake integration for PyQt bindings - it's too messy for SIP
5.x

[1] https://www.riverbankcomputing.com/software/sip/download
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yan12125 @tsujan