Add support for Generator and AsyncGenerator

[lxsmnsyc]

No description provided.

[ducan-ne]

Hi @lxsmnsyc I see this already implemented in code but is that not flagged ready to use?

Try to use it with solid start but seem like doesn't work

export const logHello = async function (message: string) {
  'use server'
  console.log(message)

  return {
    title: 'Hello World',
    async* [Symbol.asyncIterator](): AsyncIterator<number> {
      await Promise.resolve()
      yield 1
      await new Promise((resolve) => setTimeout(resolve, 1000))
      yield 2
      await new Promise((resolve) => setTimeout(resolve, 5000))
      yield 3
    },
  }
}

export const logHello = async function * (message: string) {
  "use server";
  console.log(message);

  yield { a: true }
  await new Promise((resolve) => setTimeout(resolve, 5000))

  yield { b: true }
};

[lxsmnsyc]

@ducan-ne Last time I've tested this this should work. Please provide more info.

[ducan-ne]

@lxsmnsyc
The lastest version should show catch the error
https://github.com/ducan-ne/solid-async-generator-reproduction/blob/main/src/actions.tsx
https://github.com/ducan-ne/solid-async-generator-reproduction/blob/main/src/components/Counter.tsx

for await (const value of logHello('Hello')) { not work either

Error

Uncaught (in promise) TypeError: logHello(...) is not a function or its return value is not async iterable

Or

Counter.tsx:20  Uncaught (in promise) {a: true}

This is my first time tried solid start so I'm not sure it's right way to use generator, but that's how we use it js

[lxsmnsyc]

Okay I've tested this one, this isn't a Seroval problem. Please create an issue in SolidStart.

I intend to clean up this thread since it merits its own issue thread.

[ducan-ne]

Okay, thank for your infromation

[theturtle32]

This functionality works just fine for me in SolidStart.

[lxsmnsyc]

@theturtle32 are we talking about the last comment or the entire concept

[theturtle32]

The entire concept works fine for me.

[theturtle32]

I use server functions with async generators to return chunks of streaming chat-bot responses from the server to the client via seroval.

[theturtle32]

And it appears that the related bug in SolidStart was closed as completed on May 20th.

[lxsmnsyc]

@theturtle32 yep it's been resolved. This topic is originally for the full support of Generators and AsyncGenerators (this also includes the yield) but got sidetracked