[Bug?]: Streaming/ async generator doesn't work

[ducan-ne]

Duplicates

• I have searched the existing issues

Latest version

• I have tested the latest version

Current behavior 😯

It shows a error when I consume data from a server function

Expected behavior 🤔

Should work as it was implemented in seroval

Steps to reproduce 🕹

Steps:

I've made the reproduction here
https://github.com/ducan-ne/solid-async-generator-reproduction/blob/main/src/actions.tsx
https://github.com/ducan-ne/solid-async-generator-reproduction/blob/main/src/components/Counter.tsx

Context 🔦

In case it's needed: node 20, macos

Your environment 🌎

node 20, macos

[ducan-ne]

It's not bug from sevoral, I've confirmed it here lxsmnsyc/seroval#31

[lxsmnsyc]

I've re-tested this over again, seems like a seroval thing specifically the runtime for the async iterator, but let's just keep the tracking issue here for better visibility.

[ryansolid]

I've re-tested this over again, seems like a seroval thing specifically the runtime for the async iterator, but let's just keep the tracking issue here for better visibility.

Not quite following. Is it on the seroval side?

[lxsmnsyc]

@ryansolid Yep, it was a one character mistake on the minified stream constructor. It is fixed now in 1.0.7.

This didn't really impact anything as the issue only happens when there's an immediate, single-push on the stream (stream thinks that the the value is the only thing in the buffer and ends immediately). For any other kind of delayed pushes, or immediate set of push-and-close, the stream normally works.

async function* foo() {
  "use server";
  // Adding another yield here or a sleep doesn't break.
  yield "This breaks";
  await sleep(1000);
  yield "delayed";
}

const example = await foo();
for await (const x of example) {
  console.log(x);
}

[ducan-ne]

Confirmed, the issue is now fixed.

export const getABC = async function* () {
  "use server"
  yield { abc: true }

  await new Promise((resolve) => setTimeout(resolve, 5000))
  yield { xyz: true }
}

[ryansolid]

Thanks.