Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommonSolve Interface #12

Merged
merged 17 commits into from
Jul 16, 2024
Merged

CommonSolve Interface #12

merged 17 commits into from
Jul 16, 2024

Conversation

lxvm
Copy link
Owner

@lxvm lxvm commented Jul 15, 2024

This will be a new minor version of AutoBZCore.jl that is very breaking. It replaces the old IntegralSolver interface with a init and solve! interface from CommonSolve.jl which will enable better memory management during multithreading in future work. We only try to make solve! type-stable, and in the case of NestedQuad/IAI using FunctionWrappers.jl to do so. This may be buggy in Julia v1.10 due to JuliaLang/julia#52635

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 91.47910% with 53 lines in your changes missing coverage. Please review.

Project coverage is 81.96%. Comparing base (c64678b) to head (a8b7f00).
Report is 3 commits behind head on main.

Files Patch % Lines
src/fourier.jl 82.68% 31 Missing ⚠️
src/brillouin.jl 90.54% 7 Missing ⚠️
src/domains.jl 61.11% 7 Missing ⚠️
src/interfaces.jl 88.00% 6 Missing ⚠️
src/algorithms_autosymptr.jl 97.22% 1 Missing ⚠️
src/algorithms_meta.jl 97.91% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   82.78%   81.96%   -0.83%     
==========================================
  Files          18       17       -1     
  Lines        1365     1192     -173     
==========================================
- Hits         1130      977     -153     
+ Misses        235      215      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lxvm lxvm merged commit 1f1582d into main Jul 16, 2024
8 of 9 checks passed
@lxvm lxvm deleted the interface branch July 16, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant