Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change timeout, thread joining. #4

Merged
merged 3 commits into from
Sep 3, 2014
Merged

Change timeout, thread joining. #4

merged 3 commits into from
Sep 3, 2014

Conversation

wooparadog
Copy link
Contributor

  1. timeout set to 1min. (further discussion?)
  2. all threads should be joined before quitting. Eg, in quickrestart, if call to stop exits before it times out, the actual start may called when process are STOPPING, and causes the process not to start.

@lxyu
Copy link
Owner

lxyu commented Sep 3, 2014

ehh.. the supervisor 4.0 still not rolled out?

@wooparadog
Copy link
Contributor Author

nope, they don't even have a release date. Supervisor/supervisor#131

lxyu added a commit that referenced this pull request Sep 3, 2014
@lxyu
Merge pull request #4 from wooparadog/quick-restart
8fc774d 
Change timeout, thread joining.
@lxyu lxyu merged commit 8fc774d into lxyu:master Sep 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wooparadog @lxyu