-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tel #1429
add tel #1429
Conversation
As far as I can see, |
With that I wanted to say that I like the idea to exclude it, we just do so silently. E.g. we just skip the link entirely. If you like, you can adjust the PR based on this idea. |
Oh wow, I did not know that! I'm just blind. 🙈 |
added some tests btw I think you're right: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to avoid changing the filters, as I can't see a use-case for including phone numbers right now. They can't be checked by lychee and users of the library would be required to set the field.
Apart from that, this is ready to be merged from my side.
Co-authored-by: Matthias Endler <matthias@endler.dev>
Co-authored-by: Matthias Endler <matthias@endler.dev>
Co-authored-by: Matthias Endler <matthias@endler.dev>
Thanks I guess it's mergeable now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request and for being so responsive about the changes!
add tel detection in href ?
Currently it's