Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Relative Url #15

Merged
merged 5 commits into from
Oct 20, 2020
Merged

feat: Relative Url #15

merged 5 commits into from
Oct 20, 2020

Conversation

whizsid
Copy link
Contributor

@whizsid whizsid commented Oct 19, 2020

Sorry for the delay. 😄 😆 Fixes #3

@whizsid
Copy link
Contributor Author

whizsid commented Oct 19, 2020

https://github.com/hello-rust/lychee/pull/15/files#diff-9bfca03419915f4d4c69bb43d30e158a84c63d0f68c35c4991fd659d8b158f1cR10-R12

pulldown-cmark library is splitting http://[::1] into four parts (http://,[,::1,]) when the URL is not in a URL section.

@mre
Copy link
Member

mre commented Oct 19, 2020

Looks great!
Only thing I'd add is a unit test for extract_links with a some base_url (on top of the integration test you already added). Other than that it's ready to merge from my perspective. Code is very readable.

@mre
Copy link
Member

mre commented Oct 20, 2020

Thanks for adding the unit tests and for your contribution in general @whizsid. LGTM. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support relative URLs
2 participants