Skip unsupported schemes #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lychee-bin/src/stats.rs
Outdated
| @@ -42,6 +42,10 @@ impl ResponseStats { | |||
|
|
|||
| pub(crate) fn add(&mut self, response: Response) { | |||
| let Response(source, ResponseBody { ref status, .. }) = response; | |||
| if status.is_unsupported() { | |||
| // Silently skip unsupported URIs for now | |||
There was a problem hiding this comment.
You can add a TODO: or FIXME: keyword
There was a problem hiding this comment.
Maybe I should remove the "for now" part, because I think it's a permanent thing. If we don't support a URI, we just ignore it.
There was a problem hiding this comment.
right.
So we currently support HTTP(s) and MAILTO? FILE?
It's nice to add them to readme.
| @@ -51,6 +55,7 @@ impl ResponseStats { | |||
| Status::Timeout(_) => self.timeouts += 1, | |||
| Status::Redirected(_) => self.redirects += 1, | |||
| Status::Excluded => self.excludes += 1, | |||
| Status::Unsupported(_) => (), // Just skip unsupported URI | |||
There was a problem hiding this comment.
Same as above. TODO: or FIXEME:
MichaIng
added a commit
to MichaIng/DietPi-Website
that referenced
this pull request
Jun 9, 2021
until next lychee release which contains lycheeverse/lychee#236. Try to fix verbose flag by moving it before options.
MichaIng
added a commit
to MichaIng/DietPi-Website
that referenced
this pull request
Jun 10, 2021
This requires to spin up a local webserver to be able to check internal links. The GitHub actions virtual machines come with Apache2 and Nginx on board, so we can configure and start Nginx. Additionally migrate to new Java setup action and version for v.Nu. Exclude "chrome://gpu" until next lychee release which contains lycheeverse/lychee#236.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #199