Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifiers with side-effects makes the upKey unusable #3

Closed
lydell opened this issue Jul 5, 2013 · 0 comments
Closed

Modifiers with side-effects makes the upKey unusable #3

lydell opened this issue Jul 5, 2013 · 0 comments
Labels

Comments

@lydell
Copy link
Owner

lydell commented Jul 5, 2013

Dual.set("s", _, "LAlt") seems like a combination of the s key and left alt. It is—except that you no longer can type s. That is because a lone release of alt usually means showing a hidden menu bar. Same thing for the windows keys.

It could be solved by only sending the downKey when in combination with a comboKey. However, then we'd loose the ability to combine the downKey with any key. Perhaps the behavior could be toggled per dual-role key, like Dual.set("s", _, "LAlt", true)?

Or perhaps the downKey should be sent down after the timeout has passed? Sounds like the best option to me …

@lydell lydell closed this as completed in a2863fe Jul 5, 2013
lydell added a commit that referenced this issue Aug 14, 2013
The `.down()` method no longer automatically takes care of checking if the
timeout has passed. Instead such a check is sent as a parameter. Now the
`Dual.Key` class no longer needs to reference `Dual`, and unnecessary
{downKey down} won't be sent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant